- James Cagney
- George M. Cohan
- Joan Leslie
- Mary
- Walter Huston
- Jerry Cohan
- Richard Whorf
- Sam Harris
- George Tobias
- Dietz
- Irene Manning
- Fay Templeton
- Rosemary DeCamp
- Nellie Cohan
- Jeanne Cagney
- Josie Cohan
- S.Z. Sakall
- Schwab
- George Barbier
- Erlanger
- Walter Catlett
- Manager
- Frances Langford
- Singer
- Minor Watson
- Albee
- Eddie Foy Jr.
- Eddie Foy
- Chester Clute
- Goff
- Douglas Croft
- George M. Cohan, at 13
- Patsy Lee Parsons
- Josie Cohan, As a Girl of 12
- Capt. Jack Young
- The President
- Audrey Long
- Dietz & Goff's receptionst (uncredited)
- Odette Myrtil
- Madame Bartholdi
- Clinton Rosemond
- White House butler (uncredited)
- Spencer Charters
- Colony Opera House stage manager (uncredited)
- Phyllis Kennedy
- Fanny (uncredited)
- Pat Flaherty
- Sgt. Lewis (White House guard) (uncredited)
- Leon Belasco
- Magician (uncredited)
- Michael Curtiz
- Director
- Robert Buckner
- Writer
- Edmund Joseph
- Writer
- Hal B. Wallis
- Executive Producer
- Jack L. Warner
- Executive Producer
- George M. Cohan
- Original Music
- Ray Heindorf
- Original Music
- Heinz Roemheld
- Original Music
- James Wong Howe
- Cinematographer
- George Amy
- Film Editing
- Carl Jules Weyl
- Art Director
- Milo Anderson
- Costume Design